feat(cdk): Provision ECS infrastructure for tag page rendering CODE#16321
Draft
akash1810 wants to merge 3 commits into
Draft
feat(cdk): Provision ECS infrastructure for tag page rendering CODE#16321akash1810 wants to merge 3 commits into
akash1810 wants to merge 3 commits into
Conversation
akash1810
commented
Jul 3, 2026
Comment on lines
+15
to
+21
| container: | ||
| permissions: | ||
| packages: write | ||
| needs: [production-container] | ||
| uses: ./.github/workflows/container.yml | ||
| with: | ||
| production-image-digest: ${{ needs.production-container.outputs.imageDigest }} |
Member
Author
There was a problem hiding this comment.
This container step is what runs cdk synth. This container is published to GitHub Packages and is used by the Commercial CI checks. I think there's an opportunity to simplify CI (as a separate task) by having the Commercial CI checks use the "production container". This would mean running cdk synth in a discrete step too, for improved readability.
Update tag page rendering CODE to provision ECS infrastructure but route no traffic to it.
akash1810
force-pushed
the
aa/tag-rendering-ecs
branch
from
b010457 to
d34b39d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Recommended to review commit by commit.
What does this change?
Why?
Screenshots