Remove legacy server-side AB test config#16310
Conversation
DanielCliftonGuardian
added
the
maintenance
DanielCliftonGuardian
added
the
run_chromatic
cemms1
left a comment
cemms1
left a comment
There was a problem hiding this comment.
I managed to review this yesterday but forgot to click submit 🤦
Looking really good! Just a few notes on whether we still need to keep the bundle variant test logic - not really relevant to this PR but possibly ought to have been tidied up a while ago. I don't think it necessarily needs to be done as part of this PR, just need to note down a decision one way or another
| const enableSentryReporting = !!switches.enableSentryReporting; | ||
| const isInBrowserVariantTest = | ||
| BUILD_VARIANT && tests[dcrJavascriptBundle('Variant')] === 'variant'; | ||
| const isInBrowserVariantTest = BUILD_VARIANT; |
There was a problem hiding this comment.
Not sure this makes much sense any more. It looks like this was a test run years ago and isn't running any more. Maybe we could strip out all variant bundle logic entirely. Or perhaps rename this value as it no longer really makes sense
| /** | ||
| * Server-side test names for running variant test. | ||
| * | ||
| * The name is transformed from kebab-case to camelCase, | ||
| * so we have the relevant prefix captured here. | ||
| * | ||
| * @see https://github.com/guardian/frontend/blob/main/common/app/experiments/Experiments.scala | ||
| * | ||
| * @type {(variant: 'Variant' | 'Control') => import("../src/types/config").ServerSideTestNames} | ||
| * @type {(variant: 'Variant' | 'Control') => string} |
There was a problem hiding this comment.
I don't think we need this logic any more
| ); | ||
|
|
||
| const build = getModulesBuild({ | ||
| switches: sportData.config.switches, |
2 participants
What does this change?
Now that frontend has removed its server-side AB test framework and no longer sends the abTests payload to DCR, this removes the now dead legacy plumbing.