Reserve 90px space for top-above-nav advert on tablet#16282
Draft
domlander wants to merge 2 commits into
Draft
Conversation
0802701 to
11b4ea4
Compare
Contributor
Author
|
Leaving this in draft until I have data on the breakdown of the ad sizes served in the top-above-nav slot at the tablet breakpoint. As long as more than half of the ads served in this slot are a maximum of 90px tall (the height of a leaderboard size advert), then it makes sense to make this change. Since we do serve other ad sizes in this slot that are larger than 90px in height, this change should be run as an AB test, to ensure that we are improving CLS for users, as we are intending. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
At the tablet breakpoint, between 740px and 980px, reserve 160px less vertical space for the
top-above-navadvert.Why?
We currently reserve enough space for a 970x250 (billboard) advert from the tablet breakpoint onwards. However, we only serve this ad size from the desktop breakpoint onwards. The only fixed ad size we serve on tablet, which is also the most commonly served, is the 728x90 (leaderboard) ad size1.
Screenshots
Screenshares
Before
Screen.Recording.2026-06-29.at.10.02.12.mov
After
Screen.Recording.2026-06-29.at.11.07.29.mov
Footnotes
https://github.com/guardian/commercial/blob/381fab35ac53d782469671f60b05d3eb7fd18025/core/src/ad-sizes.ts#L269 ↩