Cricket mini match stats#16279
Open
williammead wants to merge 17 commits into
Open
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a mini stats component to cricket liveblogs behind the cricket redesign abTest.
This addition touches a fair few files, but has generally been done inline with how the football mini stats component is implemented as well as borrowing styles from the cricket scorecard.
The data is filtered to only show the two batters who are currently batting. The whole component will not be shown if there are no batters (for whatever reason). The button links to the scorecard tab using "#scorecard".
I'm not sure about future plans to include other sports, but inline with the headers being extracted into a separate component I've extracted the mini stats into a separate component to make it slightly easier to update with other sports if need be in the future.
Screenshots