Skip to content

Display CTA button for apps hosted gallery articles #16260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cemms1 wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −22
Open

Display CTA button for apps hosted gallery articles #16260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2665d2e
display cta button for apps hosted gallery articles
cemms1 Jun 24, 2026
07c102b
use mobileMedium breakpoint for apps view on hosted gallery chromatic…
cemms1 Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions dotcom-rendering/src/layouts/HostedGalleryLayout.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,6 @@ import { HostedGalleryLayout } from './HostedGalleryLayout';
const meta = preview.meta({
title: 'Layouts/HostedGallery',
component: HostedGalleryLayout,
parameters: {
chromatic: {
modes: {
'light leftCol': allModes['light leftCol'],
},
},
},
});

const format = {
Expand All @@ -38,6 +31,11 @@ export const Apps = meta.story({
renderingTarget: 'Apps',
},
parameters: {
chromatic: {
modes: {
'light mobileMedium': allModes['light mobileMedium'],
},
},
config: {
renderingTarget: 'Apps',
},
Expand All @@ -55,6 +53,11 @@ export const Web = meta.story({
renderingTarget: 'Web',
},
parameters: {
chromatic: {
modes: {
'light leftCol': allModes['light leftCol'],
},
},
config: {
renderingTarget: 'Web',
},
Expand Down
28 changes: 13 additions & 15 deletions dotcom-rendering/src/layouts/HostedGalleryLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,19 +140,17 @@ export const HostedGalleryLayout = (props: WebProps | AppProps) => {
standfirst={frontendData.standfirst}
/>

{renderingTarget === 'Web' && (
<div data-print-layout="hide" css={metaStyles}>
{cta?.url && (
<div css={ctaButtonStyles}>
<CallToActionButton
linkUrl={cta.url}
accentColor={
branding?.hostedCampaignColour
}
buttonText={cta.btnText}
/>
</div>
)}
<div data-print-layout="hide" css={metaStyles}>
{cta?.url && (
<div css={ctaButtonStyles}>
<CallToActionButton
linkUrl={cta.url}
accentColor={branding?.hostedCampaignColour}
buttonText={cta.btnText}
/>
</div>
)}
{renderingTarget === 'Web' && (
<Island
priority="feature"
defer={{ until: 'visible' }}
Expand All @@ -164,8 +162,8 @@ export const HostedGalleryLayout = (props: WebProps | AppProps) => {
context="ArticleMeta"
/>
</Island>
</div>
)}
)}
</div>
</header>
<GalleryBody
renderingTarget={renderingTarget}
Expand Down
Loading