Furniture arrangement abstraction#15765
Closed
frederickobrien wants to merge 23 commits into
Closed
Conversation
frederickobrien
added
the
maintenance
frederickobrien
force-pushed
the
furniture-layout-abstraction
branch
from
18f80ce to
0f3fff4
Compare
frederickobrien
force-pushed
the
furniture-layout-abstraction
branch
from
7b85450 to
17c28b0
Compare
frederickobrien
force-pushed
the
furniture-layout-abstraction
branch
2 times, most recently
from
4a05942 to
e978bbd
Compare
Co-Authored-By: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
frederickobrien
force-pushed
the
furniture-layout-abstraction
branch
from
e978bbd to
ce23ce9
Compare
frederickobrien
force-pushed
the
furniture-layout-abstraction
branch
from
ce23ce9 to
bede688
Compare
Contributor
Author
|
I don't think this approach holds up well with more complex layouts like #15922, so closing for now. Maybe one to revisit but the vanilla approach has actually been working quite nicely so far |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Building on top of #15428, this has another stab at abstracting furniture arrangements into something that's easier to customise.
Why?
Screenshots