Skip to content

perf: fix /perf-test CI job#2448

Merged
ctron merged 1 commit into
guacsec:mainfrom
rh-jfuller:fix_perf_tools_ci
Jul 3, 2026
Merged

perf: fix /perf-test CI job#2448
ctron merged 1 commit into
guacsec:mainfrom
rh-jfuller:fix_perf_tools_ci

Conversation

@rh-jfuller

@rh-jfuller rh-jfuller commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

CI:

  • Switch perf-test workflow from a local Rust setup action to actions-rust-lang/setup-rust-toolchain@v1 with Rust toolchain 1.96.0 and caching disabled.

@sourcery-ai

sourcery-ai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaces the custom local Rust setup action in the perf-test workflow with the standard actions-rust-lang/setup-rust-toolchain action pinned to Rust 1.96.0 and disables its cache, keeping the existing Swatinem/rust-cache usage.

File-Level Changes

Change Details Files
Switch perf-test CI job to use the official Rust toolchain setup action instead of the local setup-rust composite action.
  • Replace ./.github/actions/setup-rust with actions-rust-lang/setup-rust-toolchain@v1 in the perf-test GitHub Actions workflow
  • Configure the Rust toolchain version explicitly to 1.96.0 for the perf-test job
  • Disable the setup-rust-toolchain built-in cache to avoid conflicts with the existing Swatinem/rust-cache@v2
.github/workflows/perf-test.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@rh-jfuller rh-jfuller requested a review from ctron July 3, 2026 11:14

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider aligning the specified toolchain: 1.96.0 with whatever is defined in your rust-toolchain.toml (or central Rust version config) to avoid divergence between CI and local development environments.
  • Since cache: false disables the built-in caching in setup-rust-toolchain, double-check that Swatinem/rust-cache@v2 fully covers your caching needs and that the ordering between the two actions is intentional to avoid redundant downloads.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider aligning the specified `toolchain: 1.96.0` with whatever is defined in your `rust-toolchain.toml` (or central Rust version config) to avoid divergence between CI and local development environments.
- Since `cache: false` disables the built-in caching in `setup-rust-toolchain`, double-check that `Swatinem/rust-cache@v2` fully covers your caching needs and that the ordering between the two actions is intentional to avoid redundant downloads.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rh-jfuller rh-jfuller force-pushed the fix_perf_tools_ci branch from 1b2e9b3 to 8d2518c Compare July 3, 2026 11:28
@rh-jfuller rh-jfuller force-pushed the fix_perf_tools_ci branch from 8d2518c to 3e6acb6 Compare July 3, 2026 11:46
@ctron ctron enabled auto-merge July 3, 2026 12:17
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.53%. Comparing base (d9bf2e6) to head (3e6acb6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2448      +/-   ##
==========================================
+ Coverage   71.51%   71.53%   +0.01%     
==========================================
  Files         453      453              
  Lines       27360    27360              
  Branches    27360    27360              
==========================================
+ Hits        19567    19571       +4     
+ Misses       6671     6661      -10     
- Partials     1122     1128       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctron ctron added this pull request to the merge queue Jul 3, 2026
Merged via the queue into guacsec:main with commit 5ac9f8c Jul 3, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Trustify Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants