perf: fix /perf-test CI job#2448
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplaces the custom local Rust setup action in the perf-test workflow with the standard actions-rust-lang/setup-rust-toolchain action pinned to Rust 1.96.0 and disables its cache, keeping the existing Swatinem/rust-cache usage. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider aligning the specified
toolchain: 1.96.0with whatever is defined in yourrust-toolchain.toml(or central Rust version config) to avoid divergence between CI and local development environments. - Since
cache: falsedisables the built-in caching insetup-rust-toolchain, double-check thatSwatinem/rust-cache@v2fully covers your caching needs and that the ordering between the two actions is intentional to avoid redundant downloads.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider aligning the specified `toolchain: 1.96.0` with whatever is defined in your `rust-toolchain.toml` (or central Rust version config) to avoid divergence between CI and local development environments.
- Since `cache: false` disables the built-in caching in `setup-rust-toolchain`, double-check that `Swatinem/rust-cache@v2` fully covers your caching needs and that the ordering between the two actions is intentional to avoid redundant downloads.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
1b2e9b3 to
8d2518c
Compare
8d2518c to
3e6acb6
Compare
ctron
approved these changes
Jul 3, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2448 +/- ##
==========================================
+ Coverage 71.51% 71.53% +0.01%
==========================================
Files 453 453
Lines 27360 27360
Branches 27360 27360
==========================================
+ Hits 19567 19571 +4
+ Misses 6671 6661 -10
- Partials 1122 1128 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
CI: