Skip to content

chore: add cache hit/miss instrumentation to pagination total cache #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctron merged 1 commit into from
Jul 3, 2026
Merged

chore: add cache hit/miss instrumentation to pagination total cache #2443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions common/src/db/pagination_cache.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use actix_web::{HttpResponse, ResponseError, body::BoxBody};
use moka::future::Cache;
use opentelemetry::{global, metrics::Counter};
use std::{sync::Arc, time::Duration};
use tracing::instrument;

use crate::error::ErrorInformation;

Expand Down Expand Up @@ -57,6 +58,7 @@ impl PaginationCache {
}

/// Return a cached total count, computing it at most once for concurrent requests with the same key.
#[instrument(skip(self, compute), fields(cache_hit = true))]
pub async fn cached_total(
&self,
key: String,
Expand All @@ -67,6 +69,7 @@ impl PaginationCache {
self.cache
.try_get_with(key, async {
misses.add(1, &[]);
tracing::Span::current().record("cache_hit", false);

@sourcery-ai sourcery-ai Bot Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Be cautious relying on Span::current() inside the try_get_with async closure.

Because try_get_with controls how the async closure is scheduled, it may run on a different task where the #[instrument] span is no longer current, making this record call a no-op or updating the wrong span. If you need reliable instrumentation, capture the span at the start of cached_total (e.g. let span = tracing::Span::current();) and call span.record("cache_hit", false); inside the closure instead of using Span::current() there.

compute().await
})
.await
Expand Down
Loading