🌱 [release/0.5.z] update client/openapi/trustd.yaml#1142
Merged
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Reviewer's GuideExtends the trustd OpenAPI spec to support an optional advisories summary per SBOM, wiring a reusable severity-map schema into relevant response objects and query parameters. Flow diagram for advisories query parameter and response fieldflowchart LR
client[Client]
request[Endpoint call with advisories query parameter]
response[Response with optional advisories summary per SBOM]
map[RequestedField_HashMap_HashMap severity map]
client --> request
request --> response
response --> map
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new
RequestedField_HashMap_HashMapschema name is a bit opaque; consider renaming it to something that reflects its semantic purpose (e.g., advisory severity summary map) to improve readability and future maintainability. - The
advisoriesquery parameter description references a severity summary, but the schema description focuses on severity levels; consider aligning the wording so the OpenAPI clearly explains the shape and meaning of the returned data (e.g., counts per severity). - You’ve added
advisoriesas an optional property in several response objects; double-check whether it should be included in therequiredlist (or explicitly documented as optional) to avoid ambiguity for clients about when this field is present.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new `RequestedField_HashMap_HashMap` schema name is a bit opaque; consider renaming it to something that reflects its semantic purpose (e.g., advisory severity summary map) to improve readability and future maintainability.
- The `advisories` query parameter description references a severity summary, but the schema description focuses on severity levels; consider aligning the wording so the OpenAPI clearly explains the shape and meaning of the returned data (e.g., counts per severity).
- You’ve added `advisories` as an optional property in several response objects; double-check whether it should be included in the `required` list (or explicitly documented as optional) to avoid ambiguity for clients about when this field is present.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/0.5.z #1142 +/- ##
==============================================
Coverage 51.32% 51.32%
==============================================
Files 256 256
Lines 5518 5518
Branches 1668 1668
==============================================
Hits 2832 2832
Misses 2421 2421
Partials 265 265
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
carlosthe19916
approved these changes
Jul 3, 2026
carlosthe19916
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Auto-approved
Only client/openapi/trustd.yaml changed — no manual review required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openapi.yaml of trustify has changed
Summary by Sourcery
Update trustd OpenAPI specification to expose advisory severity summaries for SBOMs and define the corresponding reusable schema.
New Features: