Skip to content

feat: conditionally show Models tab only for AIBOM SBOMs #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikanias wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: conditionally show Models tab only for AIBOM SBOMs #1095

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions client/src/app/pages/sbom-details/sbom-details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ export const SbomDetails: React.FC = () => {
tabKeys: ["info", "packages", "vulnerabilities", "models"],
});

const isAibom = sbom?.labels["kind"] === "aibom";

@sourcery-ai sourcery-ai Bot Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Accessing sbom.labels["kind"] can throw when labels is undefined.

The optional chaining only guards sbom, not labels. If labels is undefined or null, this will still throw. Use sbom?.labels?.['kind'] === 'aibom' (or sbom?.labels?.kind) so access is fully safe.


const infoTabRef = React.useRef<HTMLElement>();
const packagesTabRef = React.useRef<HTMLElement>();
const vulnerabilitiesTabRef = React.useRef<HTMLElement>();
Expand Down Expand Up @@ -229,11 +231,13 @@ export const SbomDetails: React.FC = () => {
</>
}
/>
<Tab
{...getTabProps("models")}
title={<TabTitleText>Models</TabTitleText>}
tabContentRef={modelsTabRef}
/>
{isAibom && (
<Tab
{...getTabProps("models")}
title={<TabTitleText>Models</TabTitleText>}
tabContentRef={modelsTabRef}
/>
)}
</Tabs>
</PageSection>
<PageSection>
Expand All @@ -260,13 +264,15 @@ export const SbomDetails: React.FC = () => {
>
{sbomId && <VulnerabilitiesBySbom sbomId={sbomId} />}
</TabContent>
<TabContent
{...getTabContentProps("models")}
ref={modelsTabRef}
aria-label="AI models within the SBOM"
>
{sbomId && <ModelsBySbom sbomId={sbomId} />}
</TabContent>
{isAibom && (
<TabContent
{...getTabContentProps("models")}
ref={modelsTabRef}
aria-label="AI models within the SBOM"
>
{sbomId && <ModelsBySbom sbomId={sbomId} />}
</TabContent>
)}
</PageSection>

<ConfirmDialog
Expand Down