chore: update rmcp v1.4.0#60
Merged
Merged
Conversation
Signed-off-by: mrizzi <mrizzi@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the rmcp crate to v1.4.0 for both main and dev dependencies and removes an unused ToolRouter field/initializer from the Trustify struct, with lockfile changes reflecting the dependency bump. Class diagram for Trustify struct after removing ToolRouter fieldclassDiagram
class Trustify {
+Client http_client
+String api_base_url
+String openid_issuer_url
}
class Trustify_previous {
+ToolRouter_Self tool_router
+Client http_client
+String api_base_url
+String openid_issuer_url
}
Trustify_previous -- ToolRouter_Self : used_in_field
class ToolRouter_Self
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Review Summary by QodoUpdate rmcp to v1.4.0 and remove ToolRouter field
WalkthroughsDescription• Update rmcp dependency from v1.3.0 to v1.4.0 • Remove ToolRouter field and initialization from Trustify struct • Simplify struct by eliminating tool_router management code Diagramflowchart LR
A["rmcp v1.3.0"] -- "upgrade to" --> B["rmcp v1.4.0"]
C["Trustify struct with ToolRouter"] -- "simplify" --> D["Trustify struct without ToolRouter"]
B -- "enables" --> D
File Changes1. Cargo.toml
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update rmcp dependency to v1.4.0 and remove an unused ToolRouter field from the Trustify binary.
Enhancements: