Skip to content

chore: update rmcp v1.4.0#60

Merged
mrizzi merged 1 commit into
guacsec:mainfrom
mrizzi:update-rmcp-v1.4.0
Apr 13, 2026
Merged

chore: update rmcp v1.4.0#60
mrizzi merged 1 commit into
guacsec:mainfrom
mrizzi:update-rmcp-v1.4.0

Conversation

@mrizzi

@mrizzi mrizzi commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Update rmcp dependency to v1.4.0 and remove an unused ToolRouter field from the Trustify binary.

Enhancements:

  • Bump rmcp crate to version 1.4.0 for both main and dev dependencies.
  • Simplify the Trustify struct by removing an unused ToolRouter field.

Signed-off-by: mrizzi <mrizzi@redhat.com>
@sourcery-ai

sourcery-ai Bot commented Apr 13, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the rmcp crate to v1.4.0 for both main and dev dependencies and removes an unused ToolRouter field/initializer from the Trustify struct, with lockfile changes reflecting the dependency bump.

Class diagram for Trustify struct after removing ToolRouter field

classDiagram
    class Trustify {
        +Client http_client
        +String api_base_url
        +String openid_issuer_url
    }

    class Trustify_previous {
        +ToolRouter_Self tool_router
        +Client http_client
        +String api_base_url
        +String openid_issuer_url
    }

    Trustify_previous -- ToolRouter_Self : used_in_field

    class ToolRouter_Self
Loading

File-Level Changes

Change Details Files
Bump rmcp dependency from v1.3.0 to v1.4.0 for main and dev builds.
  • Update rmcp main dependency version while keeping existing feature flags (server, transport-io, transport-streamable-http-server).
  • Update rmcp dev-dependency version while keeping existing feature flags (client, transport-child-process).
  • Refresh Cargo.lock to align with the new rmcp version and any transitive dependency updates.
Cargo.toml
Cargo.lock
Remove unused ToolRouter field from Trustify to align with updated rmcp usage or to clean up dead code.
  • Delete tool_router field from the Trustify struct definition.
  • Remove initialization of tool_router in Trustify::new (or equivalent constructor) since it is no longer used.
src/bin/common/trustify.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Update rmcp to v1.4.0 and remove ToolRouter field

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Update rmcp dependency from v1.3.0 to v1.4.0
• Remove ToolRouter field and initialization from Trustify struct
• Simplify struct by eliminating tool_router management code
Diagram
flowchart LR
  A["rmcp v1.3.0"] -- "upgrade to" --> B["rmcp v1.4.0"]
  C["Trustify struct with ToolRouter"] -- "simplify" --> D["Trustify struct without ToolRouter"]
  B -- "enables" --> D
Loading

Grey Divider

File Changes

1. Cargo.toml Dependencies +2/-2

Upgrade rmcp dependency to v1.4.0

• Update rmcp dependency from 1.3.0 to 1.4.0 in main dependencies
• Update rmcp dependency from 1.3.0 to 1.4.0 in dev-dependencies

Cargo.toml


2. src/bin/common/trustify.rs ✨ Enhancement +0/-3

Remove ToolRouter field and related code

• Remove ToolRouter import from rmcp handler module
• Remove tool_router field from Trustify struct
• Remove tool_router initialization in Trustify::new() constructor

src/bin/common/trustify.rs


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Apr 13, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mrizzi mrizzi merged commit 944ab79 into guacsec:main Apr 13, 2026
2 checks passed
@mrizzi mrizzi deleted the update-rmcp-v1.4.0 branch April 13, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant