fix: correct nindent value for application.container in Job templates#95
Merged
ctron merged 1 commit intoJul 1, 2026
Merged
Conversation
The trustification.application.container helper was included with nindent 6 instead of nindent 10 in all three init Job templates, placing the resources block at the wrong YAML indentation level when resource limits are configured. This matches the pattern already used in service Deployment templates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts Helm init Job templates to indent the shared application container helper consistently so that rendered Job container specs remain valid and match the Deployment pattern. Flow diagram for Helm Job template rendering with corrected container helper indentationflowchart TD
A[Helm values for init Jobs
createDatabase / migrateDatabase / createImporters] --> B[Job templates
020-Job.yaml]
B --> C[include trustification.common.defaultImage]
B --> D[include trustification.application.container
nindent 10]
C --> E[Rendered container spec]
D --> E
E --> F[Valid Kubernetes Job YAML
resources inside container]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
ctron
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nindent 6→nindent 10fortrustification.application.containerhelper in all three init Job templates (create-database, migrate-database, create-importers)Fixes #94
Jira: TC-4969
Test plan
helm templatewith resource overrides oncreateDatabase,migrateDatabase, andcreateImportersrenders valid YAML withresources:inside the container spec🤖 Generated with Claude Code
Summary by Sourcery
Bug Fixes: