Skip to content

feat: allow setting pagination cache ttl#86

Open
ctron wants to merge 1 commit into
mainfrom
feature/add_cache_ttl_1
Open

feat: allow setting pagination cache ttl#86
ctron wants to merge 1 commit into
mainfrom
feature/add_cache_ttl_1

Conversation

@ctron

@ctron ctron commented May 18, 2026

Copy link
Copy Markdown
Contributor

Summary by Sourcery

Add configurable TTL support for the pagination total-count cache in the server Helm chart.

New Features:

  • Introduce a paginationCacheTtl Helm value to control the TTL of the pagination total-count cache for the server component.

Documentation:

  • Document the new paginationCacheTtl Helm value and its default behavior in the values schema.

Co-authored-by: Claude <noreply@anthropic.com>
@ctron ctron requested a review from desmax74 May 18, 2026 10:32
@sourcery-ai

sourcery-ai Bot commented May 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds configurable pagination total-count cache TTL to the server Helm chart by wiring a new values.schema field through to an environment variable on the deployment.

File-Level Changes

Change Details Files
Expose a new pagination total-count cache TTL configuration option via the Helm chart and pass it to the server container as an environment variable.
  • Add optional paginationCacheTtl value to the chart schema with documentation of expected format and default behavior.
  • Template TRUSTD_PAGINATION_TOTAL_CACHE_TTL environment variable in the server Deployment when paginationCacheTtl is set.
  • Update the generated JSON values schema to include the new paginationCacheTtl property.
charts/trustify/templates/services/server/030-Deployment.yaml
charts/trustify/values.schema.yaml
charts/trustify/values.schema.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant