Add close() and context manager support to Client and AsyncClient#145
Merged
gtsystem merged 2 commits intoJul 9, 2026
Merged
Conversation
The sync Client had no way to close the underlying httpx connection pool, leaking file descriptors. The async AsyncClient had close() but lacked aclose() and async context manager support. - Add close(), __enter__, __exit__ to sync Client - Add aclose(), __aenter__, __aexit__ to AsyncClient - Add close() to GenericSyncClient - Add tests for both sync and async close/context manager - Update docs and README examples - Bump version to 0.22.0 Fixes gtsystem#144
Owner
|
CI is failing. Can you run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #144
The sync
Clienthad no way to close the underlying httpx connection pool, leaking file descriptors until process exit. The asyncAsyncClienthadclose()but lackedaclose()and async context manager support.close(),__enter__,__exit__to syncClientaclose(),__aenter__,__aexit__toAsyncClientclose()toGenericSyncClientUsage
Test plan
test_closeandtest_context_managerfor syncClienttest_close,test_aclose,test_async_context_managerforAsyncClient