Implementation of Class factory#11
Open
gruszczrob wants to merge 3 commits into
Open
Conversation
ProrokWielki
reviewed
Jun 6, 2024
ProrokWielki
left a comment
ProrokWielki
left a comment
There was a problem hiding this comment.
I don't see a point in having this class. You are trying to make very retarded python from the c++.
| } | ||
|
|
||
| ClassFactory::ClassFactory() { | ||
| writeToLogs("Drawable Engine Factory created"); |
| #include <unordered_map> | ||
| #include <vector> | ||
| #include <variant> | ||
| #include "../Logs/Logs.h" |
| #include <variant> | ||
| #include "../Logs/Logs.h" | ||
|
|
||
| using namespace std; |
There was a problem hiding this comment.
using namespace in header files is wrong
|
|
||
| class ClassFactory { | ||
| private: | ||
| shared_ptr<bool> isCorrect = make_shared<bool>(true); |
There was a problem hiding this comment.
why is it a shared_ptr and not just bool?
| T ClassFactory::getVar(const string& varName) { | ||
| if (!checkIfCorrect()) { | ||
| cout << "This class contains error, one of arguments in constructor was in incorrect type" << endl; | ||
| return T(); |
There was a problem hiding this comment.
why would you return default constructed object if the "class contains error"?
| } else { | ||
| writeToLogs("Error in public getVar: variable not found"); | ||
| cout << "Variable not found" << endl; | ||
| return T(); |
There was a problem hiding this comment.
same here. Logs are not good, and i would say not even valid error handling method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.