Implementation of Drawing engine#10
Open
gruszczrob wants to merge 2 commits into
Open
Conversation
ProrokWielki
reviewed
Jun 6, 2024
|
|
||
| class DrawingEngine : public ClassFactory { | ||
| private: | ||
| shared_ptr<int> width = make_shared<int>(); |
There was a problem hiding this comment.
why not just ints, or even better unsigned ints as the width and height shall not be negative
| shared_ptr<int> height = make_shared<int>(); | ||
|
|
||
| public: | ||
| DrawingEngine(any widthI, any heightI); |
There was a problem hiding this comment.
why would you take any as width and height when only valid type is unsigned int?
| #include <memory> | ||
| #include <any> | ||
| #include <vector> | ||
| #include "../Logs/Logs.h" |
There was a problem hiding this comment.
relative paths shall not be used for includes
| #include "../Logs/Logs.h" | ||
| #include "../ClassFactory/ClassFactory.h" | ||
|
|
||
| using namespace std; |
There was a problem hiding this comment.
| public: | ||
| DrawingEngine(any widthI, any heightI); | ||
|
|
||
| virtual void print(vector<vector<int>> grid) = 0; |
There was a problem hiding this comment.
DrawingEngine shall be able to draw the Drawables, not a buffer of ints.
The drawing engine shall have as a member a Framebuffer which would be a some type of container holding some representation of pixel, preferably (r,g,b) values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.