Fix Japanese character encoding issue #222#233
Conversation
|
Thank you very much. It would be much appreciated if you could remove non-necessary changes like single quotes to double quotes and similar. Those changes make it more complex to check the PR. |
|
ok! |
|
@MarkLevkovich Do you have any difficulties with that? Do you need any help? |
|
I'm sorry, I was very busy, I'll send changes today |
1 similar comment
|
I'm sorry, I was very busy, I'll send changes today |
|
@MarkLevkovich don't rush, there is no pressure I've asked just in case you need any help. |
- Add has_non_ascii_chars() helper function to detect Unicode strings - Skip syntax highlighting for strings with non-ASCII characters to avoid encoding issues with pygments that cause corrupted ANSI escape sequences - Japanese and other Unicode characters now display correctly - ASCII strings still get proper syntax highlighting - Fixes issue where ic() output contained corrupted ANSI codes Fixes gruns#222
MarkLevkovich
force-pushed
the
clean-japanese-fix
branch
from
55f795a to
f219f9b
Compare
|
something like this |
|
@MarkLevkovich Awesome! Could you add a test case for that too? It would be nice to cover it. |
|
Sure ! |
- Test has_non_ascii_chars() helper function with various Unicode strings - Verify that non-ASCII strings skip syntax highlighting (no ANSI codes) - Verify that ASCII strings still get proper syntax highlighting - Covers Japanese, Cyrillic, and ASCII text cases Related to gruns#222
|
@MarkLevkovich Have you run tests? I've tried to re-run builds, but they are failed. |
|
@MarkLevkovich any updates? |
|
Oh, it's been a long time, I'm sorry, I'll do it tomorrow! |
MarkLevkovich
force-pushed
the
clean-japanese-fix
branch
from
8037260 to
ebac086
Compare
|
@MarkLevkovich I've fixed tests, so now it's "deployed" |
2 participants
Fixes #222