Multi-Configuration/Multi-Installation to Built-ins#149
Open
ranelpadon wants to merge 3 commits into
Open
Conversation
|
I was looking to do a similar think (special ic instance) and was about to do a PR for at least adding the "Multi-Configuration" part to the README. Then I saw your PR which does this already 🙂 This PR is open quite a while, @gruns would you agree this is a great feature and usefull? |
turbotimon
suggested changes
May 2, 2025
|
|
||
| def install(ic='ic'): | ||
| setattr(builtins, ic, icecream.ic) | ||
| def install(attribute='ic', value=icecream.ic): |
There was a problem hiding this comment.
Maybe a better naming here? Like e.g. name and instance?
If you agree, please also change it in the uninstall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this awesome tool! :)
I usually have these use cases when working with our Python/Django projects:
ic()with context and custom prefixic()without context and prefixBut currently, these 2 cases could not exist at the same time since
configureOutput()is being applied on the sameicobject.Figured out that an effective solution is to have a way to create multiple instances of
IceCreamwherein each of them could have different configurations and could be added inbuiltinswith different names (e.g.ic()andik()):ic()with context and custom prefixik()without context and prefixHence, created this PR. I use the code changes here in our projects for some time already and it's working as intended. Likewise, updated the unit tests and README. Cheers!