xds: reject EDS drop policy with unsupported denominator#9218
Open
nvxbug wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9218 +/- ##
==========================================
+ Coverage 83.22% 83.30% +0.08%
==========================================
Files 420 420
Lines 34024 34030 +6
==========================================
+ Hits 28317 28350 +33
+ Misses 4275 4256 -19
+ Partials 1432 1424 -8
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseDropPolicy maps a FractionalPercent denominator to a divisor with a switch that has no default, so an EDS drop_overload carrying an unknown denominator enum value leaves the divisor at 0. That value reaches clusterimpl, which evaluates
d.Numerator * million / d.Denominator, and a management server sending such a resource crashes the client with an integer divide-by-zero.Reject the unsupported denominator while parsing the resource so it is NACKed, matching how parseEDSRespProto already errors on other malformed fields. Validating in the parser keeps the balancer free of divisor checks and stops one bad resource from taking down the client.