Skip to content

balancer: remove grpc.lb.pick_first.* metrics#9215

Open
deepgolani4 wants to merge 3 commits into
grpc:masterfrom
deepgolani4:master
Open

balancer: remove grpc.lb.pick_first.* metrics#9215
deepgolani4 wants to merge 3 commits into
grpc:masterfrom
deepgolani4:master

Conversation

@deepgolani4

@deepgolani4 deepgolani4 commented Jun 30, 2026

Copy link
Copy Markdown

Fixes #8752

The changes remove the three grpc.lb.pick_first.* metric registrations and their recording calls from pickfirst.go (along with the now-unneeded metricsRecorder/target fields), then update all tests and examples to assert on the equivalent grpc.subchannel.* metrics instead.

RELEASE NOTES:

  • Remove grpc.lb.pick_first.* metrics.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 30, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: deepgolani4 / name: deepgolani4 (643ead2)

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.25%. Comparing base (484f150) to head (ebca066).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9215      +/-   ##
==========================================
+ Coverage   83.19%   83.25%   +0.05%     
==========================================
  Files         420      420              
  Lines       34010    34017       +7     
==========================================
+ Hits        28295    28320      +25     
+ Misses       4281     4265      -16     
+ Partials     1434     1432       -2     
Files with missing lines Coverage Δ
balancer/pickfirst/pickfirst.go 90.07% <100.00%> (+0.31%) ⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove pickfirst metrics

1 participant