resolver: log resolver state updates at verbosity 2#9211
Open
lucacucchetti wants to merge 1 commit into
Open
Conversation
Fixes grpc#9210 addChannelzTraceEvent logs the full resolver.State (via pretty.ToJSON) on every UpdateState/NewAddress. The grpc#7437 guard `!logger.V(0) && !channelz.IsOn()` does not fire at the default verbosity (logger.V(0) is true), so with channelz off the whole state is marshaled on every update only to be discarded by the default ERROR-level logger. See grpc#9210 for benchmarks and analysis. V(2) is the verbosity used for detailed logs throughout the tree (this was the only V(0) gate). channelz, when enabled, still records the event. Behavior change: at the default verbosity the "Resolver state updated" message no longer logs; it now requires -v 2. RELEASE NOTES: * resolver: only log resolver state updates at verbosity 2 or higher, avoiding a full marshal of the resolver state on every update when channelz is off and verbose logging is disabled
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9211 +/- ##
==========================================
+ Coverage 83.21% 83.23% +0.02%
==========================================
Files 420 420
Lines 34008 34008
==========================================
+ Hits 28299 28307 +8
+ Misses 4275 4269 -6
+ Partials 1434 1432 -2
🚀 New features to boost your workflow:
|
Contributor
|
can you please sign the CLA @lucacucchetti, it will allow us to review the PR |
Author
|
Hi @mbissa, working on it apologies, looks like the legal reviewer from our side is out until next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9210
addChannelzTraceEvent logs the full resolver.State (via pretty.ToJSON) on every UpdateState/NewAddress. The #7437 guard
!logger.V(0) && !channelz.IsOn()does not fire at the default verbosity (logger.V(0) is true), so with channelz off the whole state is marshalled on every update only to be discarded by the default ERROR-level logger. See #9210 for benchmarks and analysis.V(2) is the verbosity used for detailed logs throughout the tree (this was the only V(0) gate). channelz, when enabled, still records the event.
Behavior change: at the default verbosity the "Resolver state updated" message no longer logs; it now requires -v 2.
RELEASE NOTES: