transport: return unexpected EOF for partial headers#9204
Open
buger wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9204 +/- ##
==========================================
- Coverage 83.21% 83.20% -0.01%
==========================================
Files 420 420
Lines 34008 34010 +2
==========================================
Hits 28299 28299
- Misses 4275 4277 +2
Partials 1434 1434
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9200
Track cumulative bytes read while filling a gRPC message header. If EOF occurs after any partial progress, return
io.ErrUnexpectedEOFeven when the final read call itself returned zero bytes.The regression test splits a partial header and EOF across separate recv buffer messages and verifies both the returned error and flow-control byte accounting.
RELEASE NOTES:
io.ErrUnexpectedEOF.