Skip to content

internal/transport: validate balancer and address metadata#9203

Open
buger wants to merge 1 commit into
grpc:masterfrom
buger:codex/fix-lb-address-metadata-validation
Open

internal/transport: validate balancer and address metadata#9203
buger wants to merge 1 commit into
grpc:masterfrom
buger:codex/fix-lb-address-metadata-validation

Conversation

@buger

@buger buger commented Jun 27, 2026

Copy link
Copy Markdown

Fixes #9199

Validate metadata supplied by balancer PickResult.Metadata before merging it into the outgoing context, and validate resolver/address metadata before converting it to HTTP/2 header fields.

The tests cover invalid address metadata at the transport boundary and invalid balancer metadata through an end-to-end RPC path.

RELEASE NOTES:

  • transport: Invalid metadata supplied by balancers or resolver addresses is rejected before request headers are created.

@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.22%. Comparing base (d74861e) to head (1155fc0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9203      +/-   ##
==========================================
+ Coverage   83.21%   83.22%   +0.01%     
==========================================
  Files         420      420              
  Lines       34008    34012       +4     
==========================================
+ Hits        28299    28307       +8     
- Misses       4275     4278       +3     
+ Partials     1434     1427       -7     
Files with missing lines Coverage Δ
internal/transport/http2_client.go 92.80% <100.00%> (+0.39%) ⬆️
stream.go 82.22% <100.00%> (+0.26%) ⬆️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buger buger force-pushed the codex/fix-lb-address-metadata-validation branch from a77ed9e to 99ce15e Compare June 27, 2026 08:51
@buger buger marked this pull request as ready for review June 27, 2026 08:52
@buger buger force-pushed the codex/fix-lb-address-metadata-validation branch from 99ce15e to 1155fc0 Compare June 27, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internal/transport: validate balancer and resolver-injected metadata

1 participant