grpc: Add grpc service support (A102)#9175
Conversation
fix vet script import alias check gofmt and formatting fixes for vet check Fix vet script issues: rename GRPCServiceConfig to Config, unexport HeaderValueOption, clean up package aliases, and rename unused test stream callback variables
…dsClient method, reuse bootstrap credentials structures, and move HeaderMutator to httpfilter
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9175 +/- ##
==========================================
- Coverage 83.20% 82.93% -0.27%
==========================================
Files 418 420 +2
Lines 33741 34090 +349
==========================================
+ Hits 28073 28272 +199
- Misses 4250 4364 +114
- Partials 1418 1454 +36
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for whitelisting allowed gRPC services (allowed_grpc_services) in the xDS bootstrap configuration, enabling secure connections to external processing servers with specified channel and call credentials. It also adds a HeaderMutator utility to compile and apply header mutations on gRPC metadata. The review feedback highlights several critical issues, including potential resource leaks in AllowedGrpcService.UnmarshalJSON if credential building fails midway, and multiple potential nil pointer dereferences when handling allowed gRPC services or credential plugins. Additionally, the reviewer recommends caching the bootstrap configuration in parseGRPCServiceConfig to avoid highly inefficient, repeated file I/O and JSON parsing.
|
I'd like to request that this PR be split into smaller PRs:
Some of these PRs can be in review in parallel. |
This PR adds support for grpc service as part of A102
RELEASE NOTES: