You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This rejects malformed HTTP/2 method paths in the server transport before invoking InTapHandle. The server already returns Unimplemented for malformed method names before application handlers; validating at transport time keeps tap hooks from observing non-canonical method strings.
The malformed-method regression test now installs an InTapHandle and asserts invalid method paths are rejected without invoking it.
Tests:
go test ./test -run Test/MalformedMethodPath -count=1
go test ./test -run 'Test/(MalformedMethodPath|Tap)$' -count=1
go test ./internal/transport -run 'Test/(HeadersHTTPStatusGRPCStatus|HeadersCausingStreamError)' -count=1
RELEASE NOTES:
transport: Reject malformed method names before invoking tap handlers.
❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.06%. Comparing base (b58f32d) to head (f9f665d). ⚠️ Report is 19 commits behind head on master.
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rejects malformed HTTP/2 method paths in the server transport before invoking
InTapHandle. The server already returnsUnimplementedfor malformed method names before application handlers; validating at transport time keeps tap hooks from observing non-canonical method strings.The malformed-method regression test now installs an
InTapHandleand asserts invalid method paths are rejected without invoking it.Tests:
go test ./test -run Test/MalformedMethodPath -count=1go test ./test -run 'Test/(MalformedMethodPath|Tap)$' -count=1go test ./internal/transport -run 'Test/(HeadersHTTPStatusGRPCStatus|HeadersCausingStreamError)' -count=1RELEASE NOTES: