perf(gen_build): cache ns declarations, fix #?@ reader conditional handling#93
Open
english wants to merge 1 commit into
Open
perf(gen_build): cache ns declarations, fix #?@ reader conditional handling#93english wants to merge 1 commit into
english wants to merge 1 commit into
Conversation
english
force-pushed
the
series/gen-srcs-ns-decl-cache
branch
from
4c0e5cc to
c0a4046
Compare
…ndling Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
english
force-pushed
the
series/gen-srcs-ns-decl-cache
branch
from
c0a4046 to
c709ed0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scans source directories once via
build-src-index(usingtools.reader) and caches ns declarationsfor reuse in
ns-rules. This eliminates double file reads during discovery and rule generation.Also fixes a latent bug where
get-ns-decl(usingclojure.core/read) silently droppedplatform-specific requires inside
#?@splicing reader conditionals in.cljcfiles.Since the cache now covers all source files, the buggy
get-ns-declfallback is removed entirely.Benchmark
examples/gen_srcs_bench(Hyperfine, 5 runs, 19607 namespaces, prepare: deletesrc/**/BUILD.bazel)(written by Claude)