Own face_dof[_perm] stored by default in ReferenceFE s#1320
Merged
Conversation
The default get_face_own_dofs(::ReferenceFE) and get_face_own_dofs_permutations(::ReferenceFE) are now assumed to be stored on whatever struct implements ReferenceFE. This means that the previous methods are called at construction time of the reffe. One general default for get_face_own_dofs[_permutations](reffe, ::L2Conformity) is implemented. Only LagrangianRefFEs for CDConformity need to overload the 2 args methods now. Although all test pass without modification of any test, this is slightly breaking since - existing ReferenceFE need to be updated to fill their face_own_dofs_permutations, - ovearload for concrete ReferenceFE type but abstract ::conformity now trigger ambiguous method error due to the ::L2Conformity generic fallback, it needs to be overloaded on specific Conformity (like for CDConformity)
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## moment-based #1320 +/- ##
================================================
+ Coverage 80.69% 80.75% +0.05%
================================================
Files 228 228
Lines 30255 30241 -14
================================================
+ Hits 24414 24420 +6
+ Misses 5841 5821 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored the
get_face_own_dofsandget_face_own_dofs_permutationsmethods to accomodate the fact that both are now stored inGenericRefFEby default. So the new default method (to overlead) is the singlereffeargument method, and theconf::L2Conformityfallbacks are generic.Only two overloads for the 2 arg methods are needed now, for
CDConformityon Lag reffes.This is breaking for ReferenceFE we don't implement ourselves (only), so I don't push it into
moment-based, but keep it for next breaking...Note: I think it would also make sense to do the same with
face_own_nodesandget_face_own_nodes_permutationsof the LagrangianRefFE.