Refactor of FESpaceWithLinearConstraints#1189
Draft
JordiManyer wants to merge 29 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1189 +/- ##
==========================================
+ Coverage 88.86% 89.03% +0.16%
==========================================
Files 228 229 +1
Lines 30192 30818 +626
==========================================
+ Hits 26830 27438 +608
- Misses 3362 3380 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… constructor * Changed the current inner constructor signature to allow one choose a cell_map that does not necessarily come from nodes_coordinates + linear combination of basis functions
More flexible inner UnstructuredGrid constructor
Fixing a BUG in the UnstructuredGrid outer constructor
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete overhaul of the constraint system in Gridap.
FESpaceWithLinearConstraints
ConstraintHandler
New struct ConstraintHandler: This is a less-efficient but easier to manage way of declaring constraints in Gridap. It takes constraints one by one using a high-level API, allows for handling of constraints one by one and other nice features. Once constraints have been set, one can use this structure to declare spaces.
New constructors for constraints:
TODO: