Skip to content

topology: adopt uhura as a subsystem via git submodule (no wiring)#6

Merged
softmarshmallow merged 2 commits into
mainfrom
uhura-submodule
Jul 13, 2026
Merged

topology: adopt uhura as a subsystem via git submodule (no wiring)#6
softmarshmallow merged 2 commits into
mainfrom
uhura-submodule

Conversation

@softmarshmallow

Copy link
Copy Markdown
Member

What

Adds gridaco/uhura — the client language — as a git submodule at the repo root (uhura/, pinned at its current main), and describes the relationship in the README. This shapes the topology only; there is no build wiring.

Supersedes the direction of #5 (closed): instead of importing uhura's tree as a nested workspace, uhura stays canonical in its own repository and Spock consumes it as a subsystem.

The setup

  • Spock is the ecosystem and toolchain root. We own spock on npm; uhura is taken on both registries and uhura's doctrine publishes nothing standalone. Once uhura is minimally stable, its tooling ships through the unified spock toolchain.
  • Uhura stays a distinct language. Canonical source, spec, checker, runtime, and conformance suite live in gridaco/uhura. The semantic wall holds: no fact may be authoritative in both languages; Spock is uhura's canonical provider, and the port seam stays provider-neutral.
  • The doctrine survives: "generate types, never the client" (RFD 0010) and "borrow, don't build" (RFD 0009) forbid Spock the language from building a client language — hosting a sibling's toolchain in the binary is RFD 0010's own "the binary owns generation" applied one level up.

No wiring yet — explicitly

  • Workspace members stay explicit (crates/spock-lang, crates/spock-runtime, crates/spock-cli); cargo does not see the submodule (cargo metadata verified clean).
  • CI is unaffected — actions/checkout does not fetch submodules by default.
  • cargo builds work without the submodule; --recurse-submodules is only needed to get the uhura tree.

The real wiring — spock building/embedding uhura, the contract projection (spock gen ports), and the provider adapter — lands in later milestones as uhura stabilizes.

Changes

  • .gitmodules + uhura gitlink (pinned 0bf91cf)
  • README.md: new "Uhura, the client language" section + repository-layout entry

Add gridaco/uhura as a git submodule at the repo root, pinned at its
current main, and describe the relationship in the README: Spock is the
ecosystem and toolchain root; Uhura is the client language, canonical in
its own repository, included here as a subsystem.

Topology only — the workspace members stay explicit, cargo does not see
the submodule, and CI is unaffected (actions/checkout does not fetch
submodules by default). Build integration (unified `spock` toolchain,
contract projection + provider adapter) lands later, once uhura is
minimally stable.
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@softmarshmallow, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 65f04643-99b2-4a2e-b417-de47f8fd7711

📥 Commits

Reviewing files that changed from the base of the PR and between a28ee97 and 4ceb592.

📒 Files selected for processing (1)
  • uhura

Walkthrough

Adds Uhura as a Git submodule, pins its referenced commit, and documents its relationship to Spock and its current build and CI integration status.

Changes

Uhura integration

Layer / File(s) Summary
Submodule registration and repository documentation
.gitmodules, uhura, README.md
Registers the uhura submodule, updates its pinned commit, and documents Uhura’s role, repository location, and topology-only integration status.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding Uhura as a git submodule without build wiring.
Description check ✅ Passed The description is directly aligned with the PR and explains the submodule addition, README updates, and lack of wiring.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch uhura-submodule

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Picks up the prior-art docs pass (public references: Svelte, XAML, QML,
Elm) and the subsystem README.
@softmarshmallow softmarshmallow merged commit 142f16b into main Jul 13, 2026
2 checks passed
@softmarshmallow softmarshmallow deleted the uhura-submodule branch July 13, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant