Bringing some new changes from Feature/utility library (asu cidse 2025 fall)#51
Conversation
Backend is now stable for demo
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the Cybercafe_orchestrator.sh script by introducing a UTIL_PATH variable to support Termux environments. It updates the preflight checks to verify the presence of make, sqlite3, and bash in both standard paths and the new UTIL_PATH. The run_build function is also modified to explicitly use make from UTIL_PATH, and a missing newline character is added at the end of the file. A review comment suggests improving consistency by using the UTIL_PATH variable instead of hardcoding the bash path in the shutdown instruction log message.
|
|
||
| log "Cybercafe is running." | ||
| log "To stop: bash cybercafe_orchestrator.sh shutdown" | ||
| log "To stop: /data/data/com.termux/files/usr/bin/bash cybercafe_orchestrator.sh shutdown" |
There was a problem hiding this comment.
The path to bash is hardcoded in this log message. For better maintainability and consistency with the UTIL_PATH variable defined earlier, it would be preferable to use the variable here.
| log "To stop: /data/data/com.termux/files/usr/bin/bash cybercafe_orchestrator.sh shutdown" | |
| log "To stop: "$UTIL_PATH"/bash cybercafe_orchestrator.sh shutdown" |
1 participant
No description provided.