Skip to content

Make map data optional trailing comma - #4

Open
lizard-boy wants to merge 2 commits into
masterfrom
feat/map_data_optional_trailing_comma
Open

Make map data optional trailing comma#4
lizard-boy wants to merge 2 commits into
masterfrom
feat/map_data_optional_trailing_comma

Conversation

@lizard-boy

Copy link
Copy Markdown

No description provided.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances the Thrift parser's handling of map data with optional trailing commas, focusing on improvements in the parser.ts file.

  • Updated parseMapValue function in src/main/parser.ts to handle optional trailing commas in map data
  • Fixed typo in function name from creataePropertyAssignment to createPropertyAssignment in both src/main/factory.ts and src/main/parser.ts
  • Removed unnecessary import of creataePropertyAssignment in src/main/parser.ts
  • Improved code consistency and prevented potential issues when calling the property assignment function

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant