Skip to content

[BRE-101] Remove dept-devops from CODEOWNERS #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lizard-boy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[BRE-101] Remove dept-devops from CODEOWNERS #56

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ff8284
BRE-101: Remove dept-devops from CODEOWNERS
michalchecinski Jun 7, 2024
568a67c
Update codeowners according to BRE-101 Update CODEOWNERS for CI/CD Pa…
michalchecinski Oct 14, 2024
3cc40b9
Update .github/CODEOWNERS
michalchecinski Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,22 @@
#
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

# DevOps for Actions and other workflow changes
.github/workflows @bitwarden/dept-devops
## Docker files have shared ownership ##
**/Dockerfile
**/*.Dockerfile
**/.dockerignore
**/entrypoint.sh
Comment on lines +7 to +11

@greptile-apps greptile-apps Bot Oct 19, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Docker files now have shared ownership, but no specific team is assigned. This could lead to unclear responsibility for these critical files.


# DevOps for Docker changes
**/Dockerfile @bitwarden/dept-devops
**/*.Dockerfile @bitwarden/dept-devops
**/.dockerignore @bitwarden/dept-devops
## BRE team owns these workflows ##
.github/workflows/publish.yml @bitwarden/dept-bre

## These are shared workflows ##
.github/workflows/_move_finalization_db_scripts.yml
.github/workflows/build.yml
.github/workflows/cleanup-after-pr.yml
.github/workflows/cleanup-rc-branch.yml
.github/workflows/release.yml
.github/workflows/repository-management.yml
Comment on lines +16 to +22

@greptile-apps greptile-apps Bot Oct 19, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: These workflows are listed as shared, but no specific owners are assigned. This may lead to a lack of clear responsibility for maintaining these important files.


# Database Operations for database changes
src/Sql/** @bitwarden/dept-dbops
Expand Down Expand Up @@ -55,6 +64,6 @@ bitwarden_license/src/test/Scim.ScimTest @bitwarden/team-admin-console-dev
src/Admin/Controllers/ToolsController.cs @bitwarden/team-billing-dev
src/Admin/Views/Tools @bitwarden/team-billing-dev

# Multiple owners - DO NOT REMOVE (DevOps)
# Multiple owners - DO NOT REMOVE (BRE)
**/packages.lock.json
Directory.Build.props