forked from localstack/localstack
-
Notifications
You must be signed in to change notification settings - Fork 0
add http client for in-memory gateway request dispatching #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lizard-boy
wants to merge
2
commits into
master
Choose a base branch
from
in-memory-http-client
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| """ | ||
| Core components of the runtime available as global singletons. | ||
| """ | ||
| from functools import cached_property | ||
| from typing import TYPE_CHECKING, Any | ||
|
|
||
| if TYPE_CHECKING: | ||
| from localstack.aws.app import LocalstackAwsGateway | ||
| from localstack.services.plugins import ServicePluginManager | ||
|
|
||
| gateway: "LocalstackAwsGateway" | ||
| """The Gateway processes incoming HTTP request and dispatches them to AWS services or internal resources""" | ||
|
|
||
| service_plugin_manager: "ServicePluginManager" | ||
| """The plugin manager """ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: The docstring for service_plugin_manager is incomplete |
||
|
|
||
|
|
||
| class RuntimeContainer: | ||
| """ | ||
| Class that provides the core runtime components as singleton factories. | ||
| """ | ||
|
|
||
| @cached_property | ||
| def service_plugin_manager(self) -> "ServicePluginManager": | ||
| # TODO: migrate creation here | ||
| from localstack.services.plugins import SERVICE_PLUGINS | ||
|
|
||
| return SERVICE_PLUGINS | ||
|
|
||
| @cached_property | ||
| def gateway(self) -> "LocalstackAwsGateway": | ||
| from localstack.aws.app import LocalstackAwsGateway | ||
|
|
||
| return LocalstackAwsGateway(self.service_plugin_manager) | ||
|
|
||
|
|
||
| _container = RuntimeContainer() | ||
|
|
||
|
|
||
| def __getattr__(name) -> Any: | ||
| """ | ||
| Provides dynamic and lazy access to runtime components. Can be used like this:: | ||
|
|
||
| from localstack.runtime import components | ||
|
|
||
| assert isinstance(components.gateway, LocalstackAwsGateway) | ||
|
|
||
| or even:: | ||
|
|
||
| from localstack.runtime.components import gateway | ||
|
|
||
| assert isinstance(gateway, LocalstackAwsGateway) | ||
|
|
||
| :param name: the component to get | ||
| :return: the component if it exists | ||
| """ | ||
| return getattr(_container, name) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: This import should be at the top of the file with other imports