Skip to content

Add ERC20TransferEvent and ERC721TransferEvent models - #6

Open
lizard-boy wants to merge 2 commits into
masterfrom
event-type
Open

Add ERC20TransferEvent and ERC721TransferEvent models#6
lizard-boy wants to merge 2 commits into
masterfrom
event-type

Conversation

@lizard-boy

Copy link
Copy Markdown

What changed? Why?

  • Add ERC20TransferEvent and ERC721TransferEvent models for webhook event parsing
  • Minor comment update on event filter

Qualified Impact

@lizard-boy

Copy link
Copy Markdown
Author

@greptileai

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR introduces new interfaces for ERC20 and ERC721 transfer events in the Coinbase SDK for Node.js, enhancing webhook event parsing capabilities. Key changes include:

  • Added ERC20TransferEvent interface for ERC-20 token transfers
  • Added ERC721TransferEvent interface for ERC-721 token transfers
  • Both interfaces include detailed blockchain event information (e.g., block details, transaction details, addresses involved)
  • Updated WebhookEventFilter interface with improved property descriptions

These additions will likely require updates to the Webhook class in src/coinbase/webhook.ts to properly handle and parse these new event types when received through webhooks.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants