Add ERC20TransferEvent and ERC721TransferEvent models - #6
Open
lizard-boy wants to merge 2 commits into
Open
Conversation
Author
There was a problem hiding this comment.
PR Summary
This PR introduces new interfaces for ERC20 and ERC721 transfer events in the Coinbase SDK for Node.js, enhancing webhook event parsing capabilities. Key changes include:
- Added
ERC20TransferEventinterface for ERC-20 token transfers - Added
ERC721TransferEventinterface for ERC-721 token transfers - Both interfaces include detailed blockchain event information (e.g., block details, transaction details, addresses involved)
- Updated
WebhookEventFilterinterface with improved property descriptions
These additions will likely require updates to the Webhook class in src/coinbase/webhook.ts to properly handle and parse these new event types when received through webhooks.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Qualified Impact