[chore] Hot Fix Examples Async/Await Execution - #11
Open
lizard-boy wants to merge 1 commit into
Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request updates the example files in the src/examples directory to properly handle asynchronous function calls and improve error handling.
- Wrapped main function calls in immediately invoked async functions (IIFEs) with try-catch blocks in all example files
- Removed unnecessary
awaitkeyword fromwallet.getDefaultAddress()increate_wallet.js - Ensured proper awaiting of async functions to prevent premature script termination
- Improved error logging for better debugging and user feedback in all examples
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| try { | ||
| await fundWallet(); | ||
| } catch (error) { | ||
| console.error("Error during funding wallet", error); |
There was a problem hiding this comment.
style: Consider adding more detailed error logging, such as including the error stack trace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Qualified Impact