introduce wallet activity webhook - #1
Open
lizard-boy wants to merge 17 commits into
Open
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces support for wallet activity webhooks in the Coinbase SDK for Node.js, enhancing the webhook functionality with more specific event filtering capabilities.
- Added
eventTypeFilterfield toCreateWebhookOptionstype insrc/coinbase/types.ts - Implemented
createWebhookmethod inWalletclass insrc/coinbase/wallet.ts - Updated
Webhookclass insrc/coinbase/webhook.tsto handle neweventTypeFilterparameter - Modified webhook test suite in
src/tests/webhook_test.tsto cover new functionality - Changes align with the example provided in the PR description, demonstrating proper implementation
4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
Comment on lines
+770
to
+773
| addresses: this.addresses.map(address => address.getId()!), | ||
| wallet_id: this.getId()!, | ||
| }, | ||
| signatureHeader: signatureHeader, |
There was a problem hiding this comment.
logic: this.addresses might be empty if listAddresses hasn't been called. Consider adding a check or calling listAddresses if needed
Comment on lines
+752
to
+760
| /** | ||
| * Creates a Webhook. | ||
| * | ||
| * @param notificationUri - [String] The URI to which the webhook notifications will be sent. | ||
| * @param signatureHeader - [String] (Optional) A header used to sign the webhook request, | ||
| * defaulting to an empty string. | ||
| * | ||
| * @returns [Coinbase::Webhook] The newly created webhook instance. | ||
| */ |
There was a problem hiding this comment.
style: Add @throws annotation to document potential errors
Comment on lines
+147
to
+149
| public getEventTypeFilter(): WebhookEventTypeFilter | undefined { | ||
| return this.model?.event_type_filter; | ||
| } |
There was a problem hiding this comment.
style: Add JSDoc for the return type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Qualified Impact