fix: guard against None compositor node group (#18)#19
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
get_compositor_node_group() returns None when a scene has no compositing node tree. The compositing scenes panel called .name on the result unconditionally, raising AttributeError whenever the panel was drawn while the active scene lacked a compositing tree. Resolves issue gregzaal#18. Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #18.
get_compositor_node_group()returnsNonewhen a scene has no compositing node tree (e.g. whenscene.compositing_node_groupexists but is unset, orscene.node_treeis None). The compositing scenes panel called.nameon the result unconditionally, raisingAttributeError: 'NoneType' object has no attribute 'name'whenever the panel was drawn while the active scene lacked a compositing tree.The reporter (Cristóbal Vila) hit this on Blender 5.1.1 / macOS when pressing Alt-R in the Shader Editor with the Matalogue Tree Panel open, and also when simply selecting different objects. The traceback points to the line in
MATALOGUE_PT_compositing_scenes.drawthat accesses.nameon the result.Stores the result in
comp_grouponce and guards both.nameand the later.nodesaccess in the same function.