Skip to content

Day16: Functional tests#11

Open
sergey-bleih wants to merge 4 commits into
day16from
day16-dev
Open

Day16: Functional tests#11
sergey-bleih wants to merge 4 commits into
day16from
day16-dev

Conversation

@sergey-bleih

Copy link
Copy Markdown
Collaborator

Doing the most obvious tests (not all the negative or border edge cases). Aiming to cover controllers and repositories, as those are hard to cover with proper unit tests.

Comment thread .env.test
@@ -0,0 +1,30 @@
# This file is a "template" of which env vars need to be defined for your application

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about keeping in .env.test only the diff drom .env? So, if MAILER_URL is different, then we add it to this file. In case of APP_SECRET, I think it can be removed from this file and so on.

Comment thread config/bundles.php
FOS\RestBundle\FOSRestBundle::class => ['all' => true],
JMS\SerializerBundle\JMSSerializerBundle::class => ['all' => true],
Symfony\WebpackEncoreBundle\WebpackEncoreBundle::class => ['all' => true],
Liip\FunctionalTestBundle\LiipFunctionalTestBundle::class => ['dev' => true, 'test' => true],

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need it in dev too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants