Add mismatched sequence size check#242
Open
hlascelles wants to merge 1 commit into
Open
Conversation
In Postgres, sequences can be of different sizes, for example, `integer` and `bigint`. There is essentially no reason ever to have a sequence that will have a smaller size than the primary key that it is vending IDs for. This PR adds a check to make sure that the sequence type matches that of the primary key ID column. Without it, a user may have a database column, which is `bigint`, and a sequence which is `integer` and will overflow unexpectedly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Postgres, sequences can be of different sizes, for example,
integerandbigint. There is essentially no reason ever to have a sequence that will have a smaller size than the primary key that it is vending IDs for.This PR adds a check to make sure that the sequence type matches that of the primary key ID column. Without it, a user may have a database column, which is
bigint, and a sequence which isintegerand will overflow unexpectedly.Note here the
AS integerline.Bad:
Good: