Add multidb support#240
Open
beetlegius-somos wants to merge 2 commits into
Open
Conversation
- Pass base_class through Runner and Detectors::Base (connection + models) - Rake task: ACTIVE_RECORD_DOCTOR_BASE_CLASS env, fix default for constantize - Tests and README for multi-database / custom root usage Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a configurable root model class (
base_class) forActiveRecordDoctor::Runnerand all detectors, so model discovery and database connection follow the same abstract class you use in the app (e.g.ApplicationRecord), including multi-database setups.Runneracceptsbase_class:(defaultActiveRecord::Base).Detectors::Baseuses that class for#connectionand#models(descendants).ACTIVE_RECORD_DOCTOR_BASE_CLASSand pass it to the runner; the default env string forconstantizeis corrected to"ActiveRecord::Base".Also includes a prior commit constraining minitest < 6 because
minitest-fork_executorstill hooksMinitest.run_one_method, removed in Minitest 6.