incorrect_length_validation: improve error message for array columns#236
Merged
gregnavis merged 1 commit intoJan 12, 2026
Merged
Conversation
gregnavis
approved these changes
Jan 12, 2026
gregnavis
left a comment
gregnavis
left a comment
Owner
There was a problem hiding this comment.
Great improvement! Thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgres supports array columns and when they are defined with a limit (
add_column :posts, :tags, :string, limit: 64, array: true), that limit applies to each element of the array (not to the array's length).The gem's suggestion message is currently incorrect (
the schema limits posts.tags to 64 characters but there's no length validator on Post.tags - remove the database limit or add the validator) as it suggests adding a length validator to the column, which will validate the array's length. This PR fixes that.