Skip to content

Fix missing_presence_validator ignoring attributes by prefix #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregnavis merged 1 commit into from
Sep 26, 2025
Merged

Fix missing_presence_validator ignoring attributes by prefix #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/active_record_doctor/detectors/missing_presence_validation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def detect
(config(:ignore_columns_with_default) && (column.default || column.default_function)) ||

# Explicitly ignored columns should be skipped.
config(:ignore_attributes).include?("#{model.name}.#{column.name}")
ignored?("#{model.name}.#{column.name}", config(:ignore_attributes))
end

# At this point the only columns that are left are those that DO
Expand Down
15 changes: 15 additions & 0 deletions test/active_record_doctor/detectors/missing_presence_validation_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,21 @@ def test_config_ignore_attributes
refute_problems
end

def test_config_ignore_attributes_regexp
Context.create_table(:users) do |t|
t.string :name, null: false
end.define_model

config_file(<<-CONFIG)
ActiveRecordDoctor.configure do |config|
config.detector :missing_presence_validation,
ignore_attributes: [/name/]
end
CONFIG

refute_problems
end

def test_config_ignore_polymorphic_associations_via_relationship_name
Context.create_table(:comments) do |t|
t.references :commentable, null: false, polymorphic: true
Expand Down