incorrect_length_validation: ignore STI models#213
Open
fatkodima wants to merge 1 commit into
Open
Conversation
fatkodima
force-pushed
the
ignore-sti-for-incorrect_length_validation
branch
from
ba9dddd to
51b593e
Compare
fatkodima
force-pushed
the
ignore-sti-for-incorrect_length_validation
branch
from
51b593e to
9789b25
Compare
Contributor
Author
|
@gregnavis Its been a while 😄. Time for another round of merges? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If using STI and there is no validation on the model, but there is a limit in the database for the field,
incorrect_length_validationchecker produces violations for both root model and its children.I think this is unnecessary and should be reported only for the root model, because this is the place where it should be fixed.