Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -147,14 +147,16 @@ def models_having_association_with_options(as:)
end
end

def deletable?(model)
def deletable?(model, deletable_models = [])
return true if deletable_models.include?(model)

!defines_destroy_callbacks?(model) &&
dependent_models(model).all? do |dependent_model|
foreign_key = foreign_key(dependent_model.table_name, model.table_name)

foreign_key.nil? ||
foreign_key.on_delete == :nullify || (
foreign_key.on_delete == :cascade && deletable?(dependent_model)
foreign_key.on_delete == :cascade && deletable?(dependent_model, deletable_models + [model])
)
end
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,16 @@ def test_cascade_foreign_key_and_no_callbacks_on_second_level_association
refute_problems
end

def test_cascade_and_same_class_association
Context.create_table(:users) do |t|
t.references :parent, foreign_key: { to_table: :users, on_delete: :cascade }
end.define_model do
has_many :children, class_name: "Context::User", foreign_key: :parent_id
end

refute_problems
end

def test_no_dependent_suggests_nothing
Context.create_table(:companies) do
end.define_model do
Expand Down
Loading