Fix: always cleanup db copy buffer in create_report#2979
Open
mattmundell wants to merge 5 commits into
Open
Conversation
The error case of the owner query was leaking copy_buffer.
Also move these cases up, else they have to free all the quoted_* vars.
Also move this cases up, else it has to free all the quoted_* vars.
The copy buffer still needs to be freed when count is 0.
Easier to read if they're the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Always call
db_copy_buffer_cleanupin create_report.Why
The copy buffer was sometimes leaking.
Testing
For 6dc4f87, I ran GMP commands on main and saw Asan leak logs.
Then I ran the same commands with the PR and the logs were gone.
The others are all internal/OOM errors, so are hard to test in a reproducible way.