Simplify PortaPack detection and init API#1781
Merged
martinling merged 1 commit intoJun 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we had a somewhat overcomplicated method for PortaPack detection and conditional usage.
The
portapackweak symbol was used to detect both whether PortaPack support was compiled-in (i.e. notRAD1OorJAWBREAKERbuilds), and if notNULL, could be called to detect whether a PortaPack was present at runtime, returning either a pointer to a structure orNULL.There was another weak symbol for
portapack_reference_oscillatorwhich could also beNULL.Most of this logic has been obsoleted by our new platform logic in #1715, and at this point all we need is a simple boolean test for whether a PortaPack is present.
This PR provides that in the form of
portapack_present(), and for convenience, also returns this fromportapack_init().