Rename hackrf_core.x to pins.x (3/3)#1710
Merged
mossmann merged 1 commit intoApr 28, 2026
Merged
Conversation
antoinevg
marked this pull request as ready for review
March 31, 2026 11:53
This was referenced Apr 2, 2026
Closed
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core-pins
branch
from
April 2, 2026 07:39
d476c72 to
61cc851
Compare
mossmann
self-requested a review
April 2, 2026 15:14
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core-pins
branch
4 times, most recently
from
April 7, 2026 15:26
8c1762f to
17c3be6
Compare
antoinevg
changed the title
hackrf_core.x to pins.xhackrf_core.x to pins.x (3/3)
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core-pins
branch
from
April 10, 2026 07:55
17c3be6 to
779ec1e
Compare
antoinevg
marked this pull request as draft
April 14, 2026 08:26
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core-pins
branch
from
April 22, 2026 13:07
779ec1e to
0881fc6
Compare
antoinevg
marked this pull request as ready for review
April 22, 2026 13:36
antoinevg
marked this pull request as draft
April 23, 2026 14:10
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core-pins
branch
from
April 23, 2026 15:05
15465bb to
c6d30e2
Compare
antoinevg
marked this pull request as ready for review
April 23, 2026 15:23
antoinevg
marked this pull request as draft
April 23, 2026 15:30
Member
Author
|
I've put this back in draft for now because the |
Member
|
If your concern is about GitHub representing the change to pins.x as a rename in "files changed" for the PR, I don't think you can control that detection. It is represented as a rename in the commit: 7cf005d |
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core-pins
branch
from
April 24, 2026 07:04
c6d30e2 to
5396a16
Compare
antoinevg
marked this pull request as ready for review
April 24, 2026 07:15
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core-pins
branch
from
April 24, 2026 07:18
5396a16 to
a20dcb5
Compare
antoinevg
force-pushed
the
antoinevg/refactor-hackrf-core-pins
branch
from
April 28, 2026 09:09
a20dcb5 to
679179e
Compare
Member
Author
Sometimes GitHub does a better job of reconstructing file "rename" history in non-commit views if you re-stage after a complicated rebase. 🤷 |
mossmann
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1709