Add directive definition support to opt-in features RFC#2005
Merged
martinbonnin merged 1 commit intoJun 18, 2026
Conversation
martinbonnin
approved these changes
Jun 18, 2026
|
|
||
| # includeRequiresOptIn is a list of features to include | ||
| fields(includeDeprecated: Boolean = false, includeRequiresOptIn: [String!]): [__Field!] | ||
| fields(includeDeprecated: Boolean! = false, includeRequiresOptIn: [String!]): [__Field!] |
| Cons: | ||
|
|
||
| * more complex | ||
| * requires a grammar change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the opt-in features RFC to support directives, now that directives on directive definitions are part of the draft spec.
DIRECTIVE_DEFINITIONto the@requiresOptInlocations (and the docstring), with an example marking a custom directive opt-in.__Schema/__Directiveblock — matching how the section already handles arguments and enum values.includeDeprecatedintrospection argument with the current draft spec (Boolean!instead ofBoolean).onclause to match theDirectiveDefinitiongrammar.