graph, store: Reject grafts below the base's earliest block#6610
Open
incrypto32 wants to merge 1 commit into
Open
graph, store: Reject grafts below the base's earliest block#6610incrypto32 wants to merge 1 commit into
incrypto32 wants to merge 1 commit into
Conversation
Mirrors the guard added for `graphman copy` in #6384. Without this, grafting at a block below `base.earliest_block_number` silently produces a destination missing all pre-graft mutable entity versions, and (when the base has dynamic data sources) handlers fail with `unexpected null in handler` because `data_sources$` registrations survive pruning while the entities they reference do not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Graft::validatechecks that the graft block is belowbase.latest_block, above the reorg threshold, and that the base is healthy. It does not check that the graft block is at or abovebase.earliest_block_number.When the base has been pruned past the graft block (or its start block is above it), the copy step silently leaves the destination missing all pre-graft mutable entity versions. Dynamic data source registrations in
data_sources$survive (they are never pruned), so the destination keeps listening to factory-created contracts whose backing entities are gone, producingunexpected null in handlererrors on every event.This adds the missing check, mirroring the equivalent guard added for
graphman copyin #6384.Closes #6581
Closes #6607