docs(gfql): Add Call/Let/Ref documentation (Part 2 of PR #719 improvements)#750
Merged
Conversation
- Enhanced cypher_mapping.md introduction with clearer structure - Added GFQL-Only Super-Powers section highlighting unique features - Improved section headers and organization - Added comment to edge patterns table about upper-bound only - Reordered predicates table with literal first - Added DataFrame-native explanation to translate.rst - Added reference to loading-graph-data guide These improvements make the documentation clearer and more comprehensive for users migrating from Cypher to GFQL. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Removed the reference to :ref:`loading-graph-data` as the file doesn't exist yet. The DataFrame-native explanation remains to help users understand GFQL's approach. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added comprehensive documentation for Call operations including: - Safelist architecture and security model - Categories of allowed operations (analysis, transformation, layout, encoding) - Validation stages and error codes - Prevents arbitrary code execution From PR #719 improvements (Step 52 of plan) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Added comprehensive documentation for DAG patterns including: - Let bindings for named graph operations - Ref for referencing bindings with additional operations - Complex DAG pattern examples - RemoteGraph for distributed computing - Call operations with Let bindings From PR #719 improvements (Step 53 of plan) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add Call Operations and Security section to spec/language.md - Add DAG Patterns with Let Bindings to spec/python_embedding.md - Update wire_protocol.md with new operation types - Add Python vs GFQL Let comparison to overview.rst - Add Let, Call, RemoteGraph examples to quick.rst - Create comprehensive loading_graph_data.rst guide - Add Sequencing Programs with Let to 10min.rst Part 2 of PR #719 documentation improvements
lmeyerov
force-pushed
the
docs/pr719-improvements-part2
branch
from
September 26, 2025 04:29
219ae90 to
c888a95
Compare
lmeyerov
commented
Sep 26, 2025
| connections = result._edges[result._edges['connections']] | ||
|
|
||
| Key advantages of GFQL Let: | ||
| - **Single-pass execution**: Entire DAG computed in one optimized operation |
Contributor
Author
There was a problem hiding this comment.
single pass is sus..
- Remove incorrect claim about 'single-pass execution' - Clarify that Let creates named subgraphs/operations like variables - Emphasize DAG dependency management and composability - Maintain focus on GPU acceleration benefits
lmeyerov
commented
Sep 26, 2025
| 'adults': ref('persons', [n({'age': ge(18)})]), | ||
| 'connections': ref('adults', [ | ||
| e_forward({'type': 'knows'}), | ||
| ref('adults') # Find connections between adults |
- Fix invalid Let examples that used bare matchers (now use Chain wrapper) - Add note that Chain wrapper is currently required (will be fixed) - Improve Call Operations description to be clearer about graph algorithms - Remove invalid example with ref() inside ref() chain
All GFQL operations use lowercase aliases: - let() not Let() - ref() not Ref() - call() not Call() - remote() not RemoteGraph() Fixed documentation to use correct lowercase 'remote' alias
lmeyerov
added a commit
that referenced
this pull request
Sep 26, 2025
…chain() - Replaced all .chain() calls with .gfql() - Replaced all .chain_remote() calls with .gfql_remote() - Updated references to chain_remote() and chain_remote_shape() in text - Updated code examples in markdown cells Affected notebooks: - benchmark_hops_cpu_gpu.ipynb: 31 chain() replacements - gfql_remote.ipynb: 1 chain() + 8 chain_remote() replacements - gfql_validation_fundamentals.ipynb: 6 chain() replacements - GPU_memory_consumption_tutorial.ipynb: 1 chain() replacement - temporal_predicates.ipynb: 7 chain() replacements This aligns notebooks with the API deprecation from PRs #748 and #750. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is Part 2 of the documentation improvements from PR #719, stacked on top of PR #748.
PR Stack
Changes in This PR
All Documentation Completed ✅
✅ Step 52 - spec/language.md: Added comprehensive Call Operations and Security section
✅ Step 53 - spec/python_embedding.md: Added DAG Patterns with Let Bindings section
✅ Step 54 - spec/wire_protocol.md: Updated with new operation types
✅ Step 55 - overview.rst: Added Python vs GFQL Let comparison
✅ Step 57 - quick.rst: Added Let and Call examples
✅ Step 60 - loading_graph_data.rst: Created comprehensive loading guide
✅ Step 61 - about.rst (10min.rst): Added "Sequencing Programs with Let"
Testing
Related